Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
Date: 2017-05-18 12:42:01
Message-ID: CA+OCxozssxDq-QrYac71+9C4_JiiTQy8_9UQ6FGKeoxistYYdQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, May 18, 2017 at 11:03 AM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

>
>
> On Thu, May 18, 2017 at 3:23 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Thu, May 18, 2017 at 3:00 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> Please see the discussion here: https://redmine.postgres
>>>> ql.org/issues/2308
>>>>
>>>> Would moving to the client-side translation mechanism help here? We
>>>> need to do that anyway - and it's been added since the previous discussion.
>>>>
>>>
>>> OK, at least we should checked-in code for showing title of the
>>> confirmation dialog for "Truncate".
>>>
>>
>> Right, but it doesn't work. See the first comment in the bug.
>>
>
> I am talking about the header title of the confirmation dialog. If we
> click on Truncate table without opening any alertify dialog header shows "
> AlertifyJS" and if any other alertify dialog opens before then it shows
> the header title of that dialog even if user clicks on Truncate. Please
> refer attached screenshot.
>

Oh, sure - that can be fixed. The other part does need resolution as well
though.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Robert Eckhardt 2017-05-18 13:04:03 Re: [patch] upgrade slickgrid
Previous Message Akshay Joshi 2017-05-18 10:41:45 Re: Declarative partitioning in pgAdmin4