Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
Date: 2017-05-18 10:03:25
Message-ID: CANxoLDczZcREXt3rG_nmebxmLVjM+W0TTLywXs9hY-crJJLX8Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, May 18, 2017 at 3:23 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Thu, May 18, 2017 at 3:00 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> Please see the discussion here: https://redmine.postgres
>>> ql.org/issues/2308
>>>
>>> Would moving to the client-side translation mechanism help here? We need
>>> to do that anyway - and it's been added since the previous discussion.
>>>
>>
>> OK, at least we should checked-in code for showing title of the
>> confirmation dialog for "Truncate".
>>
>
> Right, but it doesn't work. See the first comment in the bug.
>

I am talking about the header title of the confirmation dialog. If we
click on Truncate table without opening any alertify dialog header shows "
AlertifyJS" and if any other alertify dialog opens before then it shows the
header title of that dialog even if user clicks on Truncate. Please refer
attached screenshot.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Attachment Content-Type Size
image/png 31.6 KB
image/png 33.5 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2017-05-18 10:41:45 Re: Declarative partitioning in pgAdmin4
Previous Message Harshal Dhumal 2017-05-18 10:01:19 Fix for RM2421 [pgAdmin4][patch]