Re: [pgAdmin4][Patch]: number.toFixed is not function

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: number.toFixed is not function
Date: 2016-06-23 11:46:59
Message-ID: CA+OCxozOY9i2T6DdXjifQUZ0caj94TmWth3fJaoDEtxAM4W4eQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Thu, Jun 23, 2016 at 7:53 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> Please find the patch
> Issue:
> We got the following error in console log
> "number.toFixed is not function"
>
> Steps to reproduce:
> 1) Click on statistics tab.
> 1) Select any database node.
> 2) then select Databases collection node.
> 3) The above error will appear into console.
>
> Reason:
> I discussed the issue with @Murtaza and here we are explicitly
> converting values at server side to string as JSON do not directly
> support NaN & Infinity values. Because of which NumberFormatter receives
> values of type string and breaks.
>
> Solution:
> Overrides the NumberFormatter to support NaN & Infinity values.
> and we need to parse the values again in float at client side.
>
> Please review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-23 12:02:34 pgAdmin 4 commit: Fix default ACL queries which were using invalid valu
Previous Message Dave Page 2016-06-23 11:46:57 pgAdmin 4 commit: Fix "number.toFixed is not function" JS error.