From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin 4 commit: Fix "number.toFixed is not function" JS error. |
Date: | 2016-06-23 11:46:57 |
Message-ID: | E1bG361-0007sx-RF@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Fix "number.toFixed is not function" JS error.
Issue:
We got the following error in console log
"number.toFixed is not function"
Steps to reproduce:
1) Click on statistics tab.
1) Select any database node.
2) then select Databases collection node.
3) The above error will appear into console.
Reason:
I discussed the issue with @Murtaza and here we are explicitly
converting values at server side to string as JSON do not directly
support NaN & Infinity values. Because of which NumberFormatter receives
values of type string and breaks.
Solution:
Overrides the NumberFormatter to support NaN & Infinity values.
and we need to parse the values again in float at client side.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=09569a23bd7f4d91c2789c1c0c5e980959f83dbd
Author: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Modified Files
--------------
web/pgadmin/static/js/backgrid/backgrid.pgadmin.js | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-06-23 11:46:59 | Re: [pgAdmin4][Patch]: number.toFixed is not function |
Previous Message | Dave Page | 2016-06-23 11:37:29 | Re: PACTH: To fix the issue while selecting primary key in table (pgAdmin4) |