[pgAdmin4][Patch]: number.toFixed is not function

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: number.toFixed is not function
Date: 2016-06-23 06:53:59
Message-ID: CAM5-9D8MNK3twAi8tnh1u-QJwg0RRH3+HHJabxue_kgRaz=dUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Please find the patch
*Issue:*
We got the following error in console log
*"number.toFixed is not function"*

*Steps to reproduce:*
1) Click on statistics tab.
1) Select any database node.
2) then select Databases collection node.
3) The above error will appear into console.

*Reason:*
I discussed the issue with @Murtaza and here we are explicitly
converting values at server side to string as JSON do not directly
support NaN & Infinity values. Because of which NumberFormatter receives
values of type string and breaks.

*Solution:*
Overrides the NumberFormatter to support NaN & Infinity values.
and we need to parse the values again in float at client side.

Please review.

Thanks,
Surinder Kumar

Attachment Content-Type Size
handle_strings_in_NumberFormatter.patch application/octet-stream 1.1 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-06-23 09:14:26 PATCH: Allow default ACLs to be specified when creating a schema (pgAdmin4)
Previous Message Ashesh Vashi 2016-06-23 03:45:53 pgAdmin 4 commit: Use PUBLIC (in caps) whenever used as a keyword. Fixe