From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][runtime][patch]: Compilation error with Qt4 |
Date: | 2016-07-25 11:40:13 |
Message-ID: | CA+OCxozC+=25qaNTv0qGZU=f-P0cXY6T444HHzjUGOxfj=x2Zw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks - applied.
On Sat, Jul 23, 2016 at 2:39 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch file with the fix of below issues with runtime
> application.
>
> Compilation error with Qt4 as "QUrlQuery" class was introduced since Qt5.
> Client side download code has been removed as now we support server side
> download.
> We should not delete sender object inside slot. If we do so it may crash the
> application. To avoid this, we used Qt's "deleteLater" which will delete the
> objects once the processing of all the events have been done.
>
> Do review it and let us know for comments.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-07-25 11:48:15 | pgAdmin 4 commit: Allow creation of FDWs if the extension is in a non-d |
Previous Message | Dave Page | 2016-07-25 11:40:03 | pgAdmin 4 commit: Runtime fixes: |