| From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][runtime][patch]: Compilation error with Qt4 |
| Date: | 2016-07-23 13:39:32 |
| Message-ID: | CACCA4P2GP-F=Rh1CJW0YXJt8E4vtQ9mBJZbGRuRsBSXEUmOgCA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
Please find attached patch file with the fix of below issues with runtime
application.
- Compilation error with Qt4 as "QUrlQuery" class was introduced since
Qt5.
- Client side download code has been removed as now we support server
side download.
- We should not delete sender object inside slot. If we do so it may
crash the application. To avoid this, we used Qt's "deleteLater" which will
delete the objects once the processing of all the events have been done.
Do review it and let us know for comments.
Thanks,
Neel Patel
| Attachment | Content-Type | Size |
|---|---|---|
| runtime_compilation_issue.patch | application/octet-stream | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meerschaert | 2016-07-23 18:04:14 | [pgAdmin 4 UI bug] unable to add foreign keys through the UI |
| Previous Message | Devrim Gündüz | 2016-07-22 18:04:11 | Re: pgAdmin 4 v1.0-beta3 released |