| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | pgAdmin 4 commit: Runtime fixes: |
| Date: | 2016-07-25 11:40:03 |
| Message-ID: | E1bReEt-0003KR-El@gothos.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Runtime fixes:
- Compilation error with Qt4 as "QUrlQuery" class was introduced since Qt5.
- Client side download code has been removed as now we support server side download.
- We should not delete sender object inside slot. If we do so it may crash the application. To avoid this, we used Qt's "deleteLater" which will delete the objects once the processing of all the events have been done.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dcf5bfc495bea1d5b28c389335cbd89e73468aaa
Author: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Modified Files
--------------
runtime/BrowserWindow.cpp | 139 ++++------------------------------------------
runtime/BrowserWindow.h | 1 -
2 files changed, 11 insertions(+), 129 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-07-25 11:40:13 | Re: [pgAdmin4][runtime][patch]: Compilation error with Qt4 |
| Previous Message | Dave Page | 2016-07-25 11:31:41 | Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4) |