Re: [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE
Date: 2017-04-24 11:10:47
Message-ID: CA+OCxoytpKWGnpSdaUXa1_pHSyXUiN29DnU1x49rOx5Q7YN+mA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Akshay, can you review/commit this please?

On Fri, Apr 21, 2017 at 10:25 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the patch to fix the issue while using ANALYZE option in IE.
>
> *Issue:*
> We were using .startsWith() function to check the sql if it is already
> starts with explain clause or not, which was added in commit:
> c758920890309e50f47a9427039cf735ddf04d37
>
> But IE do not support .startsWith() function.
>
>
>
> - Desktop
> - Mobile
>
> FeatureChromeFirefox (Gecko)EdgeInternet ExplorerOperaSafari
> Basic support 41 17
> <https://developer.mozilla.org/en-US/Firefox/Releases/17> (17) (Yes)
> No support 28 9
>
>
> But IE do not support .startsWith() function.
>
> I have also changed the code for File Manager module as well for the same
> issue.
>
> So affected modules are,
> - Query tool
> - File Manager
>
> Please review.
> RM#2347
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-04-24 11:13:16 Re: [patch] Dependents and Dependencies in GreenPlum
Previous Message Dave Page 2017-04-24 11:10:27 Re: [pgAdmin4][PATCH] To fix the issue with displaying bigint[] values in query tool