[pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE
Date: 2017-04-21 09:25:11
Message-ID: CAKKotZS5GogwgVOxGmDVENhDSLSx-aVTuxiGeCp7YSGx89hkFw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the patch to fix the issue while using ANALYZE option in IE.

*Issue:*
We were using .startsWith() function to check the sql if it is already
starts with explain clause or not, which was added in commit:
c758920890309e50f47a9427039cf735ddf04d37

But IE do not support .startsWith() function.

- Desktop
- Mobile

FeatureChromeFirefox (Gecko)EdgeInternet ExplorerOperaSafari
Basic support 41 17
<https://developer.mozilla.org/en-US/Firefox/Releases/17> (17) (Yes)
No support 28 9

But IE do not support .startsWith() function.

I have also changed the code for File Manager module as well for the same
issue.

So affected modules are,
- Query tool
- File Manager

Please review.
RM#2347

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
RM_2347.diff text/plain 2.0 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2017-04-21 12:02:01 [pgAdmin4][Patch]: RM #2214 PostgreSQL 10.0 compatibility
Previous Message Dave Page 2017-04-21 09:20:00 Re: [patch] Update chrome driver to support chrome version 58 in tests