Re: [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

Thanks patch applied.

On Mon, Apr 24, 2017 at 4:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Akshay, can you review/commit this please?
>
> On Fri, Apr 21, 2017 at 10:25 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the patch to fix the issue while using ANALYZE option in IE.
>>
>> *Issue:*
>> We were using .startsWith() function to check the sql if it is already
>> starts with explain clause or not, which was added in commit:
>> c758920890309e50f47a9427039cf735ddf04d37
>>
>> But IE do not support .startsWith() function.
>>
>>
>>
>> - Desktop
>> - Mobile
>>
>> FeatureChromeFirefox (Gecko)EdgeInternet ExplorerOperaSafari
>> Basic support 41 17
>> <https://developer.mozilla.org/en-US/Firefox/Releases/17> (17) (Yes)
>> No support 28 9
>>
>>
>> But IE do not support .startsWith() function.
>>
>> I have also changed the code for File Manager module as well for the same
>> issue.
>>
>> So affected modules are,
>> - Query tool
>> - File Manager
>>
>> Please review.
>> RM#2347
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*