Re: [PATCH] Enhancement in sql-field control [pgAdmin4]

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Enhancement in sql-field control [pgAdmin4]
Date: 2016-03-18 15:48:38
Message-ID: CA+OCxoyfi2U8ES4epPQHX05x+H_CVy8pb4AsBduhQA-iPu6Egg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Mar 18, 2016 at 2:36 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> I have updated the backform control for sql-field.
>
> Following are the enhancements:
> 1. Added border to control which was missing earlier.
> 2. Allows user to provide height to sql-field control by specifying
> extraClasses field in model schema.
> 3. Defined new classes for sql-field control height in overrides.css
> 4. Added scrollbar to the control.
>
> Usage:
>
> {
> id: 'definition', label:'{{ _("Definition") }}', cell: 'string',
> type: 'text', mode: ['create', 'edit'], group: 'Definition',
> control: Backform.SqlFieldControl,
> extraClasses:['custom_height_css_class']
> }
>
>
> Please review the attached patch and commit if it looks good.

Thanks. Why is it full width, unlike other controls? That seems like
it needs fixing.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
image/png 63.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-03-18 16:07:14 Re: Control for selecting multiple columns [pgadmin4]
Previous Message Dave Page 2016-03-18 15:28:14 Re: Control for displaying "auto vacuum" fields into grid