From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Control for selecting multiple columns [pgadmin4] |
Date: | 2016-03-18 16:07:14 |
Message-ID: | CA+OCxowL2Nz2oKSMH378pSvTgQ_oXtEgMJQux3SJFR_TCN-xkg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> The error is at line 84 in primary_key.js (from screenshot).
>
> In primary_key.js it requires MultiSelectAjaxControl. I guess patch of
> MultiSelectControl was not applied correctly.
>
> Can you please try again.
>
> When testing it check if (in browser script tab) MultiSelectControl is
> there in node.ui.js at line no 562 (approx).
>
OK, I got it in the end. Took a lot of repeated cache clear outs though :-(
So... I see two issues:
1) The control has a black border when it has focus, unlike other controls
that have gray ones.
2) The sizing is different from other controls, whether in large screen or
small screen modes. Please see the attached screenshots. The control should
be positioned and sized just like a text control (with the exception that
it expands to multiple rows if needed, as it does).
Thanks.
[image: Inline image 2][image: Inline image 1]
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-03-18 16:52:45 | Re: PATCH: Added Node Type & Catalog objects [pgAdmin4] |
Previous Message | Dave Page | 2016-03-18 15:48:38 | Re: [PATCH] Enhancement in sql-field control [pgAdmin4] |