Re: Control for selecting multiple columns [pgadmin4]

From: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Control for selecting multiple columns [pgadmin4]
Date: 2016-03-18 11:41:27
Message-ID: CAFiP3vwU2MQV6pi5cJqHpyn3OppbckOwicBi2feyhzbEbfb1tQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

The error is at line 84 in primary_key.js (from screenshot).

In primary_key.js it requires MultiSelectAjaxControl. I guess patch of
MultiSelectControl was not applied correctly.

Can you please try again.

When testing it check if (in browser script tab) MultiSelectControl is
there in node.ui.js at line no 562 (approx).

Regards,
Harshal

--
*Harshal Dhumal*
*Software Engineer *

EenterpriseDB <http://www.enterprisedb.com>

On Fri, Mar 18, 2016 at 4:00 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Slightly expanded...
>
> [image: Inline image 1]
>
> On Fri, Mar 18, 2016 at 10:29 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> [image: Inline image 1]
>>
>> On Fri, Mar 18, 2016 at 6:32 AM, Harshal Dhumal <
>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> This seems to be some dependency issue. Can you please send me a
>>> screenshot of debugger console with js error stack.
>>>
>>>
>>> Regards,
>>> Harshal
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer *
>>>
>>>
>>>
>>> EenterpriseDB <http://www.enterprisedb.com>
>>>
>>> On Thu, Mar 17, 2016 at 10:33 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> I tried that, but get the attached error when testing. I'm on a clean
>>>> tree, with the WIP tables patch (which, by the way, doesn't look much like
>>>> Arun's design so is likely to need a lot of layout work). I've restarted,
>>>> refreshed etc.
>>>>
>>>> [image: Inline image 1]
>>>>
>>>>
>>>> On Thu, Mar 17, 2016 at 6:04 AM, Harshal Dhumal <
>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> I have used same control in primary key constraint for selecting
>>>>> multiple columns. So to test this control please extract attached table.zip
>>>>> file under schema node. This zip contains table, column and constraint node
>>>>> with primary key support (as constraint node has dependency on table and
>>>>> column node). Also you will need to apply multiselect control patch
>>>>> separately as this zip does not contain the same.
>>>>>
>>>>>
>>>>> Thank you,
>>>>>
>>>>> Harshal
>>>>>
>>>>>
>>>>> --
>>>>> *Harshal Dhumal*
>>>>> *Software Engineer *
>>>>>
>>>>>
>>>>>
>>>>> EenterpriseDB <http://www.enterprisedb.com>
>>>>>
>>>>> On Tue, Mar 15, 2016 at 10:13 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>
>>>>>> It seems to be missing the test dialogue?
>>>>>>
>>>>>> On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal <
>>>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> PFA generalized updated patch for backform multiSelectControl.
>>>>>>>
>>>>>>> --
>>>>>>> *Harshal Dhumal*
>>>>>>> *Software Engineer *
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> EenterpriseDB <http://www.enterprisedb.com>
>>>>>>>
>>>>>>> On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal <
>>>>>>> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> PFA backform control for selecting multiple columns.(This control
>>>>>>>> depends on column node.)
>>>>>>>>
>>>>>>>> Usage:
>>>>>>>>
>>>>>>>> {
>>>>>>>> id: 'columns', label: '{{ _('Columns') }}',
>>>>>>>> type: 'collection', group: '{{ _('Definition') }}', editable:true,
>>>>>>>> canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,
>>>>>>>> deps: ['index'], node: 'column',
>>>>>>>> model: pgBrowser.Node.Model.extend({
>>>>>>>> keys: ['column'],
>>>>>>>> defaults: {
>>>>>>>> column: undefined
>>>>>>>> }
>>>>>>>> })
>>>>>>>> }
>>>>>>>>
>>>>>>>>
>>>>>>>> Note: When using this control model should have *column*
>>>>>>>> attribute. And node property should be *column*.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Harshal Dhumal*
>>>>>>>> *Software Engineer *
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> EenterpriseDB <http://www.enterprisedb.com>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Sent via pgadmin-hackers mailing list (
>>>>>>> pgadmin-hackers(at)postgresql(dot)org)
>>>>>>> To make changes to your subscription:
>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-03-18 11:43:04 pgAdmin 4 commit: Renaming a server, when it was connected, should not
Previous Message Ashesh Vashi 2016-03-18 11:24:13 pgAdmin 4 commit: Resolved an issue related to not able to select grant