[PATCH] Enhancement in sql-field control [pgAdmin4]

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [PATCH] Enhancement in sql-field control [pgAdmin4]
Date: 2016-03-18 14:36:53
Message-ID: CAM5-9D-bKzmB=4-2UpByzqqkJDNi5a1zADt_0ak0-VFEQFF5Jg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

I have updated the backform control for sql-field*.*

Following are the enhancements:
1. Added border to control which was missing earlier.
2. Allows user to provide height to sql-field control by specifying
*extraClasses* field in model schema.
3. Defined new classes for sql-field control height in overrides.css
4. Added scrollbar to the control.

*Usage: *

{
id: 'definition', label:'{{ _("Definition") }}', cell: 'string',
type: 'text', mode: ['create', 'edit'], group: 'Definition',
control: *Backform.SqlFieldControl*,
*extraClasses:['custom_height_css_class']*
}

Please review the attached patch and commit if it looks good.

Thanks,
Surinder Kumar

Attachment Content-Type Size
sql_field_control_enhancement.patch application/octet-stream 2.5 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-03-18 15:01:15 Re: pgAdmin4 PATCH: Domain Module
Previous Message Murtuza Zabuawala 2016-03-18 14:14:31 PATCH: Updated catalog names [pgAdmin4]