Re: Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data
Date: 2017-05-15 14:05:44
Message-ID: CA+OCxoyXTVGZZw=RMwpH=PvoNJHfsrPNLwtDt_iAYmBLPQFZuA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

I've committed a modified version of this patch following some discussion
on IM with Surinder.

Thanks Surinder!

On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi
>
> The regression test cases for 'copy row' was failing.
> This patch was assuming that each selected row will have primary key due
> to selection was not working. Fixed.
>
> Please find revised patch.
>
> Thanks
> Surinder Kumar
>
> On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> This patch contains following changes:
>>
>> 1) When a new row is added, allow to delete if changes are not saved.
>>
>> 2) Disable new row selection if primary key is not given but changes are
>> saved on server.
>>
>> 3) Copy and paste one or more rows, then add new row doesn't work(entered
>> value doesn't appear).
>>
>> 4) After deleting a row, add new row doesn't work.
>>
>> 5) New row added with explicitly given primary key should not disabled.
>>
>>
>> Please review.
>>
>> Thanks,
>> Surinder Kumar
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2017-05-15 14:22:53 Build failed in Jenkins: pgadmin4-master-python27 #121
Previous Message Dave Page 2017-05-15 14:04:19 pgAdmin 4 commit: Various improvements to the NULL/DEFAULT handling in