Re: Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi hackers,

We were checking out the selection functionality after this commit--looks
like selection no longer works for single cells.

If you press a cell in the grid the following message is console logged:

sqleditor.js:869 Uncaught TypeError: Cannot read property 'indexOf' of undefined
at SlickGrid.<anonymous> (sqleditor.js:869)
at Event.notify (slick.core.js:143)
at trigger (slick.grid.js:1067)
at setActiveCellInternal (slick.grid.js:2693)
at HTMLDivElement.handleClick (slick.grid.js:2469)
at HTMLDivElement.dispatch (jquery-1.11.2.js:4665)
at HTMLDivElement.$event.dispatch (jquery.event.drag-2.2.js:374)
at HTMLDivElement.elemData.handle (jquery-1.11.2.js:4333)

​

Thanks
George & Joao

On Mon, May 15, 2017 at 10:05 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> I've committed a modified version of this patch following some discussion
> on IM with Surinder.
>
> Thanks Surinder!
>
> On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi
>>
>> The regression test cases for 'copy row' was failing.
>> This patch was assuming that each selected row will have primary key due
>> to selection was not working. Fixed.
>>
>> Please find revised patch.
>>
>> Thanks
>> Surinder Kumar
>>
>> On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar <
>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> This patch contains following changes:
>>>
>>> 1) When a new row is added, allow to delete if changes are not saved.
>>>
>>> 2) Disable new row selection if primary key is not given but changes are
>>> saved on server.
>>>
>>> 3) Copy and paste one or more rows, then add new row doesn't
>>> work(entered value doesn't appear).
>>>
>>> 4) After deleting a row, add new row doesn't work.
>>>
>>> 5) New row added with explicitly given primary key should not disabled.
>>>
>>>
>>> Please review.
>>>
>>> Thanks,
>>> Surinder Kumar
>>>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>