From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][patch]: String evaluation issue |
Date: | 2016-04-18 12:39:37 |
Message-ID: | CA+OCxoyWHjtFiDU6GbexDtCDqyfgMndE29rfVesmdiheWBTvkg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied.
On Monday, April 18, 2016, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch file containing the fix for the below issue.
> This issue is reported by Dave during the debugger code review and we have
> removed the same issue from other files where we used.
>
> *Issue :- *
>
> When we use below string to form the error message then it will not work
> because Jinja will evaluate the string " + err.errormsg + " before it gets
> evaluated as JS by the browser.
>
> *alertify.error("{{ _('" + err.errormsg + "') }}");*
>
>
> Do review it and let us know for any comments.
>
> Thanks,
> Neel Patel
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2016-04-18 13:34:06 | [PATCH] Tables node (pgAdmin4) |
Previous Message | Dave Page | 2016-04-18 12:39:29 | pgAdmin 4 commit: Don't try to use the template engine's gettext on Jav |