| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | Ganesh Jaybhay <ganesh(dot)jaybhay(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries |
| Date: | 2020-04-15 08:01:34 |
| Message-ID: | CA+OCxoyEh0zeLCHN_y9e=S3Fdynsp76-eUw+o_PEGH00JT67Fg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Wed, Apr 15, 2020 at 8:25 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Ganesh
>
> As per my understanding, the dictionary names from "pg_catalog" should not
> be schema-qualified. Please make appropriate changes and send the patch
> again.
>
> @Dave/@Ashesh thoughts?
>
Maybe I'm missing something, but I don't see why not. If anything, I'd
argue it's defensive programming, that makes good sense.
>
>
> On Tue, Apr 14, 2020 at 5:37 PM Ganesh Jaybhay <
> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to add schema qualified dictionary names in FTS
>> configuration to overcome the confusion of duplicate dictionary names.
>>
>> Also modified the resql test cases accordingly.
>>
>> Please review.
>>
>> Regards,
>> Ganesh Jaybhay
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Khushboo Vashi | 2020-04-15 08:03:23 | Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as. |
| Previous Message | Akshay Joshi | 2020-04-15 07:25:14 | Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries |