Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ganesh Jaybhay <ganesh(dot)jaybhay(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries
Date: 2020-04-15 09:42:14
Message-ID: CANxoLDcYW4qxCTj8KR2g_uuUGnHTJzRZdiLFegL9gaB8X3RuVw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave

On Wed, Apr 15, 2020 at 1:31 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Wed, Apr 15, 2020 at 8:25 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Ganesh
>>
>> As per my understanding, the dictionary names from "pg_catalog" should
>> not be schema-qualified. Please make appropriate changes and send the patch
>> again.
>>
>> @Dave/@Ashesh thoughts?
>>
>
> Maybe I'm missing something, but I don't see why not. If anything, I'd
> argue it's defensive programming, that makes good sense.
>

I am talking about showing that on GUI, please refer the below
screenshot:
[image: FTS_Config.png]

>
>
>>
>>
>> On Tue, Apr 14, 2020 at 5:37 PM Ganesh Jaybhay <
>> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to add schema qualified dictionary names in FTS
>>> configuration to overcome the confusion of duplicate dictionary names.
>>>
>>> Also modified the resql test cases accordingly.
>>>
>>> Please review.
>>>
>>> Regards,
>>> Ganesh Jaybhay
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2020-04-15 09:43:30 Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size
Previous Message Khushboo Vashi 2020-04-15 09:36:11 Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size