Re: [pgAdmin4][Patch]: RM1858 - File Manager does not honour the file type while traversing the directories

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM1858 - File Manager does not honour the file type while traversing the directories
Date: 2016-10-21 13:26:27
Message-ID: CA+OCxoy8=9tBUFfZDAB01EhM5EPLMZFyAA0n3TtG8XG+00+O7Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Thu, Oct 20, 2016 at 1:37 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> When a File Manager is closed by clicking cancel button. Its dom element not
> destroyed.. So on traversing into directories, when it tries to get
> currently selected file type, it looks into the dom element but it gets dom
> of previous dialogs not of currently dialog.
>
> Now whenever an instance of File Manager is closed. its dom elements are
> also destroyed.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-10-21 13:32:28 pgAdmin 4 commit: Handle non-ascii responses from the server when conne
Previous Message Dave Page 2016-10-21 13:26:16 pgAdmin 4 commit: Ensure the File Manager honours the file type while t