[pgAdmin4][Patch]: RM1858 - File Manager does not honour the file type while traversing the directories

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: RM1858 - File Manager does not honour the file type while traversing the directories
Date: 2016-10-20 12:37:06
Message-ID: CAM5-9D-8Qay+8TTBF=cYGkurQisftBfddpenWp-V2msaFrHEnQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

When a File Manager is closed by clicking cancel button. Its dom element
not destroyed.. So on traversing into directories, when it tries to get
currently selected file type, it looks into the dom element but it gets dom
of previous dialogs not of currently dialog.

Now whenever an instance of File Manager is closed. its dom elements are
also destroyed.

Please find attached patch and review.

Thanks,
Surinder Kumar

Attachment Content-Type Size
RM1858.patch application/octet-stream 4.0 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2016-10-20 13:00:56 pgAdmin 4 commit: Fixes #1843 Function definition does not match value
Previous Message Ashesh Vashi 2016-10-20 11:08:50 Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220