From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin 4 commit: Ensure the File Manager honours the file type while t |
Date: | 2016-10-21 13:26:16 |
Message-ID: | E1bxZpw-0001s4-HU@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Ensure the File Manager honours the file type while traversing the directories. Fixes #1858
When a File Manager is closed by clicking cancel button. Its dom element not destroyed.. So on traversing into directories, when it tries to get currently selected file type, it looks into the dom element but it gets dom of previous dialogs not of currently dialog.
Now whenever an instance of File Manager is closed. its dom elements are also destroyed.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1e66119ef58e4d310daaece697e3546ec1380712
Author: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Modified Files
--------------
.../templates/file_manager/js/file_manager.js | 28 +++++++++++++++++-----
.../sqleditor/templates/sqleditor/js/sqleditor.js | 7 ++++++
2 files changed, 29 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-10-21 13:26:27 | Re: [pgAdmin4][Patch]: RM1858 - File Manager does not honour the file type while traversing the directories |
Previous Message | Surinder Kumar | 2016-10-21 13:18:11 | [pgAdmin4][Patch]: RM1867 - User can not drop package body under properties section |