| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Teng Zhang <tezhang(at)pivotal(dot)io> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Jing Li <jingli(at)pivotal(dot)io>, Hao Wang <haowang(at)pivotal(dot)io>, Dave Cramer <davecramer(at)gmail(dot)com>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Subject: | Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor |
| Date: | 2017-09-11 12:04:15 |
| Message-ID: | CA+OCxox9gnSi+s=2_uDbyK2zfd6JvDxMm3XrZK8sJbz6fVthbQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Akshay, can you review/commit this please?
Thanks.
On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang <tezhang(at)pivotal(dot)io> wrote:
> Hi Hackers,
>
> Attached is a patch that makes SQL editor show syntax highlighting with
> Greenplum keywords.
>
> - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
> - Use "x-gpsql" mode for sql editor when connecting database is greenplum
> - No behavior change to pg and ppas, still use "x-pgsql"
>
> Regards,
> Hao Wang & Teng Zhang
>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anthony DeBarros | 2017-09-11 12:10:22 | Re: pgAdmin 4 v2.0-rc1 builds |
| Previous Message | Dave Page | 2017-09-11 12:03:49 | Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor |