| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Jing Li <jingli(at)pivotal(dot)io> |
| Cc: | Teng Zhang <tezhang(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Hao Wang <haowang(at)pivotal(dot)io>, Dave Cramer <davecramer(at)gmail(dot)com> |
| Subject: | Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor |
| Date: | 2017-09-11 12:03:49 |
| Message-ID: | CA+OCxowDTWhOpvQopx1xsLdQe4JsiXSrx2rLTmF7roRt-Tru5g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Mon, Sep 11, 2017 at 11:13 AM, Jing Li <jingli(at)pivotal(dot)io> wrote:
> Can we get this patch into the 2.0 release?
>
Shouldn't be a problem. It didn't make todays build though.
>
>
> On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezhang(at)pivotal(dot)io wrote:
>
>> Hi Hackers,
>>
>> Attached is a patch that makes SQL editor show syntax highlighting with
>> Greenplum keywords.
>>
>> - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
>> - Use "x-gpsql" mode for sql editor when connecting database is greenplum
>> - No behavior change to pg and ppas, still use "x-pgsql"
>>
>> Regards,
>> Hao Wang & Teng Zhang
>>
>>
>>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2017-09-11 12:04:15 | Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor |
| Previous Message | Fahar Abbas | 2017-09-11 11:31:07 | Re: pgAdmin 4 v2.0-rc1 builds |