Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

From: Jing Li <jingli(at)pivotal(dot)io>
To: Teng Zhang <tezhang(at)pivotal(dot)io>
Cc: "pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org>, Hao Wang <haowang(at)pivotal(dot)io>, Dave Cramer <davecramer(at)gmail(dot)com>
Subject: Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor
Date: 2017-09-11 10:13:03
Message-ID: 5e6dea68-e9a7-b098-72fb-2bf51dcc9972@mixmax.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Can we get this patch into the 2.0 release?

On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezhang(at)pivotal(dot)io wrote:
Hi Hackers,
Attached is a patch that makes SQL editor show syntax highlighting with
Greenplum keywords.
- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum- No
behavior change to pg and ppas, still use "x-pgsql"
Regards,Hao Wang & Teng Zhang

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2017-09-11 10:15:17 Jenkins build is back to normal : pgadmin4-master-python26 #439
Previous Message Dave Page 2017-09-11 10:06:33 pgAdmin 4 commit: Use wheel==0.29.0 with Python 2.6 and 3.3.