| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Teng Zhang <tezhang(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Jing Li <jingli(at)pivotal(dot)io>, Hao Wang <haowang(at)pivotal(dot)io>, Dave Cramer <davecramer(at)gmail(dot)com> |
| Subject: | Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor |
| Date: | 2017-09-11 12:10:28 |
| Message-ID: | CANxoLDeTun+TWymoCG=uqVHAskNSisPU3gQH6G=g=1TEc8mNLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Mon, Sep 11, 2017 at 5:34 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Akshay, can you review/commit this please?
>
Sure Dave.
>
> Thanks.
>
> On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang <tezhang(at)pivotal(dot)io> wrote:
>
>> Hi Hackers,
>>
>> Attached is a patch that makes SQL editor show syntax highlighting with
>> Greenplum keywords.
>>
>> - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
>> - Use "x-gpsql" mode for sql editor when connecting database is greenplum
>> - No behavior change to pg and ppas, still use "x-pgsql"
>>
>> Regards,
>> Hao Wang & Teng Zhang
>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surinder Kumar | 2017-09-11 12:18:53 | Re: pgAdmin 4 v2.0-rc1 builds |
| Previous Message | Anthony DeBarros | 2017-09-11 12:10:22 | Re: pgAdmin 4 v2.0-rc1 builds |