Re: Build failed in Jenkins: pgadmin4-master-python34 #440

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Build failed in Jenkins: pgadmin4-master-python34 #440
Date: 2018-01-22 11:02:47
Message-ID: CA+OCxox2dx_X10WnoBX2=Jkgyb_O+8Yp8TYNc9BirhbbaE-9xQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Dave,
>
> We need to make habit of running the following command before committing any
> javascript files.
>>
>> yarn run linter

We do - it's called when creating the bundle, which I always do when testing.

This newer version of ESLint seems to be picking up more than the
older one though.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2018-01-22 11:02:51 Re: Build failed in Jenkins: pgadmin4-master-python34 #440
Previous Message Ashesh Vashi 2018-01-22 10:59:52 Re: Build failed in Jenkins: pgadmin4-master-python34 #440