Re: Build failed in Jenkins: pgadmin4-master-python34 #440

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Build failed in Jenkins: pgadmin4-master-python34 #440
Date: 2018-01-22 11:05:27
Message-ID: CAG7mmow7-pxmwZ665dVGvqG-NCG3F8Ux62VoKLLVanK1qR_tXA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Jan 22, 2018 at 4:32 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi
> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> > Dave,
> >
> > We need to make habit of running the following command before committing
> any
> > javascript files.
> >>
> >> yarn run linter
>
> We do - it's called when creating the bundle, which I always do when
> testing.
>
> This newer version of ESLint seems to be picking up more than the
> older one though.
>
Yeah - looks like that's the case.

I fixed all linter issues with older version of ESlint last week.

--
Thanks & Regards,

Ashesh Vashi

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2018-01-22 11:09:19 Build failed in Jenkins: pgadmin4-master-python27 #452
Previous Message Dave Page 2018-01-22 11:04:52 pgAdmin 4 commit: Correctly display SQL of multiple objects on the SQL