Re: Build failed in Jenkins: pgadmin4-master-python34 #440

On Mon, Jan 22, 2018 at 4:29 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Dave,
>
> We need to make habit of running the following command before committing
> any javascript files.
>
>> *yarn run linter*
>
> Surinder,

Please run the following command to fix most of the indentation issues, but
- you'll need to fix rest of the issues by yourself.

> *yarn run linter --fix*

-- Thanks, Ashesh

>
> -- Thanks, Ashesh
>
> On Mon, Jan 22, 2018 at 4:25 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi Surinder,
>>
>> It seems that updating ESLint exposed various issues. Can you take a
>> look ASAP please?
>>
>> Thanks.
>>
>>
>> ---------- Forwarded message ----------
>> From: pgAdmin 4 Jenkins <jenkins(at)pgadmin(dot)org>
>> Date: Mon, Jan 22, 2018 at 10:53 AM
>> Subject: Build failed in Jenkins: pgadmin4-master-python34 #440
>> To: pgadmin-hackers(at)postgresql(dot)org, dpage(at)pgadmin(dot)org
>>
>>
>> See <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/44
>> 0/display/redirect?page=changes>
>>
>> Changes:
>>
>> [Dave Page] Update ESLint requirement to support --fix-dry-run
>>
>> [Dave Page] Ensure clickable images/buttons have appropriate tooltips for
>> screen
>>
>> ------------------------------------------
>> [...truncated 401.64 KB...]
>> 228:1 error Expected indentation of 20 spaces but found 22 indent
>> 229:1 error Expected indentation of 22 spaces but found 24 indent
>> 230:1 error Expected indentation of 22 spaces but found 24 indent
>> 231:1 error Expected indentation of 22 spaces but found 24 indent
>> 232:1 error Expected indentation of 20 spaces but found 22 indent
>> 233:1 error Expected indentation of 18 spaces but found 20 indent
>> 236:1 error Expected indentation of 20 spaces but found 22 indent
>> 237:1 error Expected indentation of 22 spaces but found 24 indent
>> 238:1 error Expected indentation of 22 spaces but found 24 indent
>> 239:1 error Expected indentation of 22 spaces but found 24 indent
>> 240:1 error Expected indentation of 20 spaces but found 22 indent
>> 543:1 error Expected indentation of 14 spaces but found 12 indent
>> 544:1 error Expected indentation of 16 spaces but found 14 indent
>> 546:1 error Expected indentation of 16 spaces but found 14 indent
>> 547:1 error Expected indentation of 18 spaces but found 16 indent
>> 548:1 error Expected indentation of 18 spaces but found 16 indent
>> 549:1 error Expected indentation of 16 spaces but found 14 indent
>> 551:1 error Expected indentation of 16 spaces but found 14 indent
>> 552:1 error Expected indentation of 14 spaces but found 12 indent
>> 553:1 error Expected indentation of 14 spaces but found 12 indent
>> 554:1 error Expected indentation of 16 spaces but found 14 indent
>> 556:1 error Expected indentation of 16 spaces but found 14 indent
>> 557:1 error Expected indentation of 18 spaces but found 16 indent
>> 558:1 error Expected indentation of 18 spaces but found 16 indent
>> 559:1 error Expected indentation of 16 spaces but found 14 indent
>> 561:1 error Expected indentation of 16 spaces but found 14 indent
>> 562:1 error Expected indentation of 14 spaces but found 12 indent
>> 593:1 error Expected indentation of 14 spaces but found 12 indent
>> 594:1 error Expected indentation of 16 spaces but found 14 indent
>> 596:1 error Expected indentation of 16 spaces but found 14 indent
>> 597:1 error Expected indentation of 18 spaces but found 16 indent
>> 598:1 error Expected indentation of 18 spaces but found 16 indent
>> 599:1 error Expected indentation of 16 spaces but found 14 indent
>> 601:1 error Expected indentation of 16 spaces but found 14 indent
>> 602:1 error Expected indentation of 14 spaces but found 12 indent
>> 603:1 error Expected indentation of 14 spaces but found 12 indent
>> 604:1 error Expected indentation of 16 spaces but found 14 indent
>> 606:1 error Expected indentation of 16 spaces but found 14 indent
>> 607:1 error Expected indentation of 18 spaces but found 16 indent
>> 608:1 error Expected indentation of 18 spaces but found 16 indent
>> 609:1 error Expected indentation of 16 spaces but found 14 indent
>> 611:1 error Expected indentation of 16 spaces but found 14 indent
>> 612:1 error Expected indentation of 14 spaces but found 12 indent
>> 778:43 error Unnecessary escape character: \.
>> no-useless-escape
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/browser/static/js/error.js>
>> 2:1 error Expected indentation of 2 spaces but found 4 indent
>> 3:1 error Expected indentation of 2 spaces but found 0 indent
>> 4:1 error Expected indentation of 4 spaces but found 2 indent
>> 6:1 error Expected indentation of 4 spaces but found 2 indent
>> 7:1 error Expected indentation of 6 spaces but found 4 indent
>> 8:1 error Expected indentation of 8 spaces but found 6 indent
>> 21:1 error Expected indentation of 8 spaces but found 6 indent
>> 22:1 error Expected indentation of 10 spaces but found 8 indent
>> 34:1 error Expected indentation of 8 spaces but found 6 indent
>> 36:1 error Expected indentation of 8 spaces but found 6 indent
>> 37:1 error Expected indentation of 8 spaces but found 6 indent
>> 38:1 error Expected indentation of 10 spaces but found 8 indent
>> 39:1 error Expected indentation of 10 spaces but found 8 indent
>> 40:1 error Expected indentation of 8 spaces but found 6 indent
>> 41:1 error Expected indentation of 6 spaces but found 4 indent
>> 42:1 error Expected indentation of 4 spaces but found 2 indent
>> 44:1 error Expected indentation of 4 spaces but found 2 indent
>> 45:1 error Expected indentation of 2 spaces but found 0 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/browser/static/js/menu.js>
>> 150:1 error Expected indentation of 8 spaces but found 10 indent
>> 151:1 error Expected indentation of 6 spaces but found 8 indent
>> 178:1 error Expected indentation of 10 spaces but found 12 indent
>> 179:1 error Expected indentation of 8 spaces but found 10 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/browser/static/js/node.js>
>> 408:1 error Expected indentation of 18 spaces but found 20 indent
>> 409:1 error Expected indentation of 20 spaces but found 22 indent
>> 410:1 error Expected indentation of 20 spaces but found 22 indent
>> 411:1 error Expected indentation of 18 spaces but found 20 indent
>> 412:1 error Expected indentation of 16 spaces but found 18 indent
>> 691:1 error Expected indentation of 12 spaces but found 14 indent
>> 694:1 error Expected indentation of 16 spaces but found 14 indent
>> 705:1 error Expected indentation of 12 spaces but found 14 indent
>> 708:1 error Expected indentation of 16 spaces but found 14 indent
>> 740:1 error Expected indentation of 20 spaces but found 18 indent
>> 741:1 error Expected indentation of 20 spaces but found 18 indent
>> 982:1 error Expected indentation of 10 spaces but found 8 indent
>> 994:1 error Expected indentation of 10 spaces but found 12 indent
>> 998:1 error Expected indentation of 14 spaces but found 16 indent
>> 999:1 error Expected indentation of 14 spaces but found 16 indent
>> 1344:1 error Expected indentation of 16 spaces but found 14 indent
>> 1345:1 error Expected indentation of 16 spaces but found 14 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/dashboard/static/js/dashboard.js>
>> 481:1 error Expected indentation of 12 spaces but found 10 indent
>> 482:1 error Expected indentation of 12 spaces but found 10 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/misc/bgprocess/static/js/bgprocess.js>
>> 84:1 error Expected indentation of 14 spaces but found 16 indent
>> 85:1 error Expected indentation of 16 spaces but found 18 indent
>> 86:1 error Expected indentation of 16 spaces but found 18 indent
>> 87:1 error Expected indentation of 16 spaces but found 18 indent
>> 88:1 error Expected indentation of 14 spaces but found 16 indent
>> 89:1 error Expected indentation of 12 spaces but found 14 indent
>> 279:1 error Expected indentation of 18 spaces but found 16 indent
>> 355:1 error Expected indentation of 14 spaces but found 12 indent
>> 356:1 error Expected indentation of 16 spaces but found 12 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/misc/depends/static/js/depends.js>
>> 48:1 error Expected indentation of 12 spaces but found 14 indent
>> 49:1 error Expected indentation of 12 spaces but found 14 indent
>> 79:1 error Expected indentation of 14 spaces but found 16 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/misc/file_manager/static/js/utility.js>
>> 702:1 error Expected indentation of 12 spaces but found 14 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/misc/statistics/static/js/statistics.js>
>> 78:1 error Expected indentation of 6 spaces but found 8 indent
>> 81:1 error Expected indentation of 6 spaces but found 8 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/preferences/static/js/preferences.js>
>> 261:1 error Expected indentation of 16 spaces but found 18 indent
>> 263:1 error Expected indentation of 18 spaces but found 20 indent
>> 264:1 error Expected indentation of 16 spaces but found 18 indent
>> 302:1 error Expected indentation of 16 spaces but found 18 indent
>> 316:1 error Expected indentation of 14 spaces but found 16 indent
>> 317:1 error Expected indentation of 14 spaces but found 16 indent
>> 327:1 error Expected indentation of 18 spaces but found 20 indent
>> 342:1 error Expected indentation of 14 spaces but found 16 indent
>> 343:1 error Expected indentation of 14 spaces but found 16 indent
>> 344:1 error Expected indentation of 14 spaces but found 16 indent
>> 346:1 error Expected indentation of 16 spaces but found 18 indent
>> 347:1 error Expected indentation of 18 spaces but found 20 indent
>> 348:1 error Expected indentation of 16 spaces but found 18 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/bundle/app.js>
>> 21:1 error Expected indentation of 2 spaces but found 4 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/js/backform.pgadmin.js>
>> 452:1 error Expected indentation of 8 spaces but found 10 indent
>> 515:1 error Expected indentation of 10 spaces but found 8 indent
>> 516:1 error Expected indentation of 10 spaces but found 8 indent
>> 567:1 error Expected indentation of 10 spaces but found 12 indent
>> 568:1 error Expected indentation of 10 spaces but found 12 indent
>> 569:1 error Expected indentation of 10 spaces but found 12 indent
>> 570:1 error Expected indentation of 12 spaces but found 14 indent
>> 571:1 error Expected indentation of 12 spaces but found 14 indent
>> 572:1 error Expected indentation of 12 spaces but found 14 indent
>> 573:1 error Expected indentation of 12 spaces but found 14 indent
>> 574:1 error Expected indentation of 10 spaces but found 12 indent
>> 575:1 error Expected indentation of 8 spaces but found 10 indent
>> 1027:36 error Missing trailing comma
>> comma-dangle
>> 1592:1 error Expected indentation of 14 spaces but found 16 indent
>> 1627:1 error Expected indentation of 14 spaces but found 16 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/js/backgrid.pgadmin.js>
>> 61:1 error Expected indentation of 12 spaces but found 10 indent
>> 62:1 error Expected indentation of 12 spaces but found 10 indent
>> 63:1 error Expected indentation of 14 spaces but found 12 indent
>> 64:1 error Expected indentation of 12 spaces but found 10 indent
>> 516:1 error Expected indentation of 8 spaces but found 10 indent
>> 597:1 error Expected indentation of 4 spaces but found 6 indent
>> 598:1 error Expected indentation of 6 spaces but found 8 indent
>> 599:1 error Expected indentation of 4 spaces but found 6 indent
>> 1242:1 error Expected indentation of 10 spaces but found 8 indent
>> 1243:1 error Expected indentation of 12 spaces but found 8 indent
>> 1244:1 error Expected indentation of 12 spaces but found 8 indent
>> 1272:1 error Expected indentation of 10 spaces but found 8 indent
>> 1273:1 error Expected indentation of 12 spaces but found 8 indent
>> 1274:1 error Expected indentation of 12 spaces but found 8 indent
>> 1463:1 error Expected indentation of 10 spaces but found 8 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/js/gettext.js>
>> 17:50 error Unnecessary escape character: \) no-useless-escape
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/js/pgadmin.js>
>> 44:20 error Unnecessary escape character: \. no-useless-escape
>> 44:22 error Unnecessary escape character: \- no-useless-escape
>> 61:77 error Unnecessary escape character: \/ no-useless-escape
>> 61:79 error Unnecessary escape character: \- no-useless-escape
>> 61:90 error Unnecessary escape character: \/ no-useless-escape
>> 61:92 error Unnecessary escape character: \- no-useless-escape
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/js/sqleditor/keyboard_shortcuts.js>
>> 27:1 error Expected indentation of 4 spaces but found 5 indent
>> 29:1 error Expected indentation of 2 spaces but found 4 indent
>> 33:1 error Expected indentation of 4 spaces but found 5 indent
>> 35:1 error Expected indentation of 2 spaces but found 4 indent
>> 39:1 error Expected indentation of 4 spaces but found 5 indent
>> 41:1 error Expected indentation of 2 spaces but found 4 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/js/sqleditor_utils.js>
>> 22:1 error Expected indentation of 12 spaces but found 20 indent
>> 23:1 error Expected indentation of 10 spaces but found 18 indent
>> 49:1 error Expected indentation of 10 spaces but found 12 indent
>> 83:1 error Expected indentation of 14 spaces but found 18 indent
>> 85:1 error Expected indentation of 16 spaces but found 22 indent
>> 89:1 error Expected indentation of 20 spaces but found 34 indent
>> 93:1 error Expected indentation of 16 spaces but found 18 indent
>> 98:1 error Expected indentation of 20 spaces but found 34 indent
>> 102:1 error Expected indentation of 16 spaces but found 18 indent
>> 107:1 error Expected indentation of 20 spaces but found 34 indent
>> 111:1 error Expected indentation of 16 spaces but found 18 indent
>> 116:1 error Expected indentation of 20 spaces but found 34 indent
>> 124:1 error Expected indentation of 20 spaces but found 34 indent
>> 145:1 error Expected indentation of 18 spaces but found 26 indent
>> 165:1 error Expected indentation of 16 spaces but found 24 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/jsx/history/detail/history_detail_message.jsx>
>> 24:1 error Expected indentation of 12 spaces but found 14 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/jsx/history/detail/history_detail_query.jsx>
>> 57:1 error Expected indentation of 10 spaces but found 16 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/static/jsx/history/detail/history_error_message.jsx>
>> 18:1 error Expected indentation of 6 spaces but found 11 indent
>> 19:1 error Expected indentation of 6 spaces but found 11 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/tools/debugger/static/js/debugger_ui.js>
>> 30:1 error Expected indentation of 6 spaces but found 8 indent
>> 41:1 error Expected indentation of 6 spaces but found 8 indent
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/tools/debugger/static/js/direct.js>
>> 424:27 error Unnecessary escape character: \ . no-useless-escape
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/tools/import_export/static/js/import_export.js>
>> 28:15 error Unnecessary escape character: \" no-useless-escape
>> 307:21 error Unnecessary escape character: \" no-useless-escape
>> 308:21 error Unnecessary escape character: \" no-useless-escape
>> 334:21 error Unnecessary escape character: \" no-useless-escape
>> 335:21 error Unnecessary escape character: \" no-useless-escape
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/tools/sqleditor/static/js/sqleditor.js>
>> 556:1 error Expected indentation of 14 spaces but found 16 indent
>> 1935:1 error Expected indentation of 8 spaces but found 10 indent
>> 2203:1 error Expected indentation of 14 spaces but found 12 indent
>> 2253:1 error Expected indentation of 14 spaces but found 16 indent
>> 2378:1 error Expected indentation of 14 spaces but found 12 indent
>> 2822:71 error Unnecessary escape character: \/
>> no-useless-escape
>> 2857:67 error Unnecessary escape character: \/
>> no-useless-escape
>>
>> <https://jenkins.pgadmin.org/job/pgadmin4-master-python34/ws
>> /web/pgadmin/tools/user_management/static/js/user_management.js>
>> 246:51 error Unnecessary escape character: \/ no-useless-escape
>>
>> ✖ 842 problems (842 errors, 0 warnings)
>> 759 errors, 0 warnings potentially fixable with the `--fix` option.
>>
>> error Command failed with exit code 1.
>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
>> this command.
>> ERROR: Failed to lint the Javascript code.
>> ERROR: Error detected when running the Jasmine tests.
>> Build step 'Execute shell' marked build as failure
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>