Re: [pgAdmin4][PATCH] Consolidating gray colors in the application

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: Robert Eckhardt <reckhardt(at)pivotal(dot)io>, Shruti B Iyer <siyer(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Matthew Kleiman <mkleiman(at)pivotal(dot)io>
Subject: Re: [pgAdmin4][PATCH] Consolidating gray colors in the application
Date: 2017-06-07 15:31:57
Message-ID: CA+OCxox024g-VkUTGetuZkFa-yT8pt_mxqUtkZcg0fNABqLTWg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Wed, Jun 7, 2017 at 3:48 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> I have used classes 'bg-gray-2 border-gray-3' for styling header and footer
> of properties panel which are also used in other places.
>
> Please find attached patch.
>
>
> On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <reckhardt(at)pivotal(dot)io>
> wrote:
>>
>> Thank you.
>>
>> -- Rob
>>
>> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>
>>> Sure I will send.
>>>
>>> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
>>>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>> > Hi
>>>> >
>>>> > With the latest pull, I found:
>>>> > The header color of Properties panel disappears and background color
>>>> > of
>>>> > footer area in Edit Properties panel is changed.
>>>>
>>>> Oh, I missed that :-(. Can you come up with a quick fix using the new
>>>> classes?
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Joao Pedro De Almeida Pereira 2017-06-07 18:10:04 Re: [pgAdmin4][Patch]: Load module's JS files only when required
Previous Message Dave Page 2017-06-07 15:31:51 pgAdmin 4 commit: Fix a couple of missing greys.