From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, Robert Eckhardt <reckhardt(at)pivotal(dot)io>, Shruti B Iyer <siyer(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Matthew Kleiman <mkleiman(at)pivotal(dot)io> |
Subject: | Re: [pgAdmin4][PATCH] Consolidating gray colors in the application |
Date: | 2017-06-08 05:18:25 |
Message-ID: | CAKKotZST7Ph2PgRSzm6XFN5NOnApKTH2L0j7BO_V1N7HFKGbmg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hello,
I think we could have use some different grey colour shade for SlickGrid
headers from wcDocker panel, It does not look bad but as a end user I'm not
able to differentiate between them now, please refer screenshot attached.
Is this expected with new design style?
[image: Inline image 1]
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Jun 7, 2017 at 9:01 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, applied.
>
> On Wed, Jun 7, 2017 at 3:48 PM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> > Hi
> >
> > I have used classes 'bg-gray-2 border-gray-3' for styling header and
> footer
> > of properties panel which are also used in other places.
> >
> > Please find attached patch.
> >
> >
> > On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <reckhardt(at)pivotal(dot)io>
> > wrote:
> >>
> >> Thank you.
> >>
> >> -- Rob
> >>
> >> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar
> >> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> >>>
> >>> Sure I will send.
> >>>
> >>> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>>>
> >>>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
> >>>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> >>>> > Hi
> >>>> >
> >>>> > With the latest pull, I found:
> >>>> > The header color of Properties panel disappears and background color
> >>>> > of
> >>>> > footer area in Edit Properties panel is changed.
> >>>>
> >>>> Oh, I missed that :-(. Can you come up with a quick fix using the new
> >>>> classes?
> >>>>
> >>>> --
> >>>> Dave Page
> >>>> Blog: http://pgsnake.blogspot.com
> >>>> Twitter: @pgsnake
> >>>>
> >>>> EnterpriseDB UK: http://www.enterprisedb.com
> >>>> The Enterprise PostgreSQL Company
> >>>
> >>>
> >>
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
Attachment | Content-Type | Size |
---|---|---|
![]() |
image/png | 61.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-06-08 05:51:05 | [pgAdmin4][PATCH] Fix handling of double precision[] type |
Previous Message | Surinder Kumar | 2017-06-08 04:38:19 | [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button |