From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
---|---|
To: | Robert Eckhardt <reckhardt(at)pivotal(dot)io> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Shruti B Iyer <siyer(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Matthew Kleiman <mkleiman(at)pivotal(dot)io> |
Subject: | Re: [pgAdmin4][PATCH] Consolidating gray colors in the application |
Date: | 2017-06-07 14:48:18 |
Message-ID: | CAM5-9D__jp-b=M72NDNzN-405BTtAp99j_4Hhv268a_bzYayHg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
I have used classes 'bg-gray-2 border-gray-3' for styling header and footer
of properties panel which are also used in other places.
Please find attached patch.
On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <reckhardt(at)pivotal(dot)io>
wrote:
> Thank you.
>
> -- Rob
>
> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Sure I will send.
>>
>> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
>>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>> > Hi
>>> >
>>> > With the latest pull, I found:
>>> > The header color of Properties panel disappears and background color of
>>> > footer area in Edit Properties panel is changed.
>>>
>>> Oh, I missed that :-(. Can you come up with a quick fix using the new
>>> classes?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
Attachment | Content-Type | Size |
---|---|---|
apply_color_to_properties_header_footer_panel.patch | application/octet-stream | 876 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Surinder Kumar | 2017-06-07 15:03:41 | Re: Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool |
Previous Message | Dave Page | 2017-06-07 14:46:56 | Re: [pgAdmin4] [PATCH] History Tab rewrite in React |