Re: PATCH: don't save empty favourite queries

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: don't save empty favourite queries
Date: 2014-06-25 09:54:17
Message-ID: CA+OCxox-1CHygPQJ+MxgZN45YExDUPy+ubxwdiBS--2rtKhKMQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - patch applied!

On Sun, Jun 22, 2014 at 7:13 PM, Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru> wrote:
> Hello again!
> Recently I found, that when you open dialog "Add favourite" in query editor
> and close it without any changes, then in the dialog "Manage favourites"
> there is appears an empty element (i.e. with blank title). I think it's not
> quite right, so I put a small condition in dlgAddFavourite.cpp. It means
> that only if OK button is enabled, then we have a well-formed favourite
> query and can add new item to the favourites. If there will be a free time,
> please take a look at this patch. If I'm wrong, maybe you'll find an correct
> solution of the issue?
> Thank you.
>
> --
> Dmitriy Olshevskiy
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2014-06-27 07:57:11 Re: Fix for a problem with auto reconnection
Previous Message Dave Page 2014-06-25 09:54:05 pgAdmin III commit: Ensure Favourite queries are only saved when the OK