| From: | Dmitriy Olshevskiy <olshevskiy87(at)bk(dot)ru> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers(at)postgresql(dot)org |
| Subject: | PATCH: don't save empty favourite queries |
| Date: | 2014-06-22 18:13:49 |
| Message-ID: | 53A71CDD.8020208@bk.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hello again!
Recently I found, that when you open dialog "Add favourite" in query
editor and close it without any changes, then in the dialog "Manage
favourites" there is appears an empty element (i.e. with blank title). I
think it's not quite right, so I put a small condition in
dlgAddFavourite.cpp. It means that only if OK button is enabled, then we
have a well-formed favourite query and can add new item to the
favourites. If there will be a free time, please take a look at this
patch. If I'm wrong, maybe you'll find an correct solution of the issue?
Thank you.
--
Dmitriy Olshevskiy
| Attachment | Content-Type | Size |
|---|---|---|
| t-7-don-t-save-empty-favourite-queries.patch | text/plain | 713 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | rohtodeveloper | 2014-06-23 06:39:28 | please review source(SQLServer compatible) |
| Previous Message | Christoph Zwerschke | 2014-06-22 14:57:21 | Re: Fix for a problem with auto reconnection |