Re: Fix for a problem with auto reconnection

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Christoph Zwerschke <cito(at)online(dot)de>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fix for a problem with auto reconnection
Date: 2014-06-27 07:57:11
Message-ID: CA+OCxowc5A88oK_BALL3a6vcpOoHHhsJy3ji2ezb9tGuJN7kbw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Ashesh - your thoughts on this? I'm not sure I see how resetting
needColQuoting would prevent a datlastsysoid error, though I admit I
haven't had a chance to dive into the code yet.

On Sun, Jun 22, 2014 at 3:57 PM, Christoph Zwerschke <cito(at)online(dot)de> wrote:
> Thanks for looking into this. The problem with the wrong encoding is now
> gone, but another problem appeared:
>
> When the connection is reestablished, I get an additional alert with an
> error message "Column not found in pgSet: "datlastsysoid".
>
> The problem seems to be that needColQuoting is not reset to false in the
> Reset() method as it is done in the Reconnect() method.
>
> Wenn I add the line "needColQuoting = false" before the call to Initialize()
> in the Reset() method, everything works as expected.
>
> -- Christoph
>
>
> Am 17.06.2014 08:35, schrieb Ashesh Vashi:
>
>> Dave,
>>
>> PFA - moved the initialisation code in a separate function, and called
>> that function from the "Reset" function too.
>> Please take a look at it.
>>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Christoph Zwerschke 2014-06-27 08:58:02 Re: Fix for a problem with auto reconnection
Previous Message Dave Page 2014-06-25 09:54:17 Re: PATCH: don't save empty favourite queries