| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL WWW <pgsql-www(at)postgresql(dot)org> |
| Subject: | Re: Download navigation UX |
| Date: | 2020-07-07 15:53:30 |
| Message-ID: | CA+OCxowm0s9=HLoo-h=SuYiosAJCHeRib0ves=2kQcO+p=dcmw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
On Tue, Jul 7, 2020 at 2:15 PM Jonathan S. Katz <jkatz(at)postgresql(dot)org>
wrote:
> On 7/7/20 6:02 AM, Dave Page wrote:
> > Here's an updated patch (based on Jonathan's update) which combines the
> > inline handler patch and removes the inline handlers from the main patch.
>
> Looking good. One comment:
>
> Given there's nothing dynamic about serving the new apt.js /
> download.js, we don't need to serve those dynamically from the Django
> app. We can just plop them into "/media/js", e.g.
> "/media/js/download.js" and then this becomes:
>
> <script type="text/javascript"
> src="/media/js/download.js?{{gitrev}}"></script>
>
Thanks - committed with that change.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2020-07-07 15:54:07 | Re: Download navigation UX |
| Previous Message | Magnus Hagander | 2020-07-07 13:23:28 | Re: Download navigation UX |