Re: Download navigation UX

From: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
To: Dave Page <dpage(at)pgadmin(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL WWW <pgsql-www(at)postgresql(dot)org>
Subject: Re: Download navigation UX
Date: 2020-07-07 13:15:12
Message-ID: c95e7d33-dc6d-8713-5e34-d289d87cc3be@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On 7/7/20 6:02 AM, Dave Page wrote:
> Here's an updated patch (based on Jonathan's update) which combines the
> inline handler patch and removes the inline handlers from the main patch.

Looking good. One comment:

Given there's nothing dynamic about serving the new apt.js /
download.js, we don't need to serve those dynamically from the Django
app. We can just plop them into "/media/js", e.g.
"/media/js/download.js" and then this becomes:

<script type="text/javascript"
src="/media/js/download.js?{{gitrev}}"></script>

Thanks,

Jonathan

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2020-07-07 13:18:48 Re: Download navigation UX
Previous Message Dave Page 2020-07-07 10:02:22 Re: Download navigation UX