From: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL WWW <pgsql-www(at)postgresql(dot)org> |
Subject: | Re: Download navigation UX |
Date: | 2020-07-07 15:54:07 |
Message-ID: | d5d262d5-6e19-e49a-e0bc-bffd76e8f41a@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-www |
On 7/7/20 11:53 AM, Dave Page wrote:
>
>
> On Tue, Jul 7, 2020 at 2:15 PM Jonathan S. Katz <jkatz(at)postgresql(dot)org
> <mailto:jkatz(at)postgresql(dot)org>> wrote:
>
> On 7/7/20 6:02 AM, Dave Page wrote:
> > Here's an updated patch (based on Jonathan's update) which
> combines the
> > inline handler patch and removes the inline handlers from the main
> patch.
>
> Looking good. One comment:
>
> Given there's nothing dynamic about serving the new apt.js /
> download.js, we don't need to serve those dynamically from the Django
> app. We can just plop them into "/media/js", e.g.
> "/media/js/download.js" and then this becomes:
>
> <script type="text/javascript"
> src="/media/js/download.js?{{gitrev}}"></script>
>
>
> Thanks - committed with that change.
Awesome, thanks!
Jonathan
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2020-07-07 15:55:35 | Re: Download navigation UX |
Previous Message | Dave Page | 2020-07-07 15:53:30 | Re: Download navigation UX |