Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin
Date: 2017-01-17 09:46:10
Message-ID: CA+OCxowNqMFic_RqAJyeHkq1FNTQv2eHMCCMuMUfNrvLfsYLBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks. What log output do you get?

On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>
wrote:

> Hi Dave.
>
> After applying this patch on Windows 2012 server 64 with Python 2.7.11 on
> EPAS-9.6 server, Maintenance DB and Backup database failed.
>
> Please find attached the snapshot.
>
> Kind Regards,
>
> On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>>
>>>> KeyError: u'end_time'
>>>>
>>>> The status file contains:
>>>>
>>>> {"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363,
>>>> "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}
>>>>
>>>
>>> Thanks for reviewing the patch.
>>> Please find the updated patch.
>>>
>>> Changes:
>>> - Using now ValueError instead of json.JSONDecodeError, which is
>>> subclass of ValueError, to allow to it to work with 2.6+ python.
>>> - Checking the existence of value in dict before accessing it.
>>>
>>>
>>>
>> That seems to work for me in a brief test on my Mac. :-)
>>
>> Fahar; are you able to apply and test this patch on Windows and Linux, in
>> server and desktop modes? Basically all the external processes should be
>> tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs
>> available at the moment due to travel.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Syed Fahar Abbas
> Quality Management Group
>
> EnterpriseDB Corporation
> Phone Office: +92-51-835-8874
> Phone Direct: +92-51-8466803 <+92%2051%208466803>
> Mobile: +92-333-5409707 <+92%20333%205409707>
> Skype ID: syed.fahar.abbas
> Website: www.enterprisedb.com
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-01-17 09:52:01 Re: [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL
Previous Message Fahar Abbas 2017-01-17 09:44:49 Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin