Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

Hi Dave.

After applying this patch on Windows 2012 server 64 with Python 2.7.11 on
EPAS-9.6 server, Maintenance DB and Backup database failed.

Please find attached the snapshot.

Kind Regards,

On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>>
>>> KeyError: u'end_time'
>>>
>>> The status file contains:
>>>
>>> {"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363,
>>> "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}
>>>
>>
>> Thanks for reviewing the patch.
>> Please find the updated patch.
>>
>> Changes:
>> - Using now ValueError instead of json.JSONDecodeError, which is subclass
>> of ValueError, to allow to it to work with 2.6+ python.
>> - Checking the existence of value in dict before accessing it.
>>
>>
>>
> That seems to work for me in a brief test on my Mac. :-)
>
> Fahar; are you able to apply and test this patch on Windows and Linux, in
> server and desktop modes? Basically all the external processes should be
> tested - backup, restore & maintenance (vacuum) etc). I don't have any VMs
> available at the moment due to travel.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com