| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru> |
| Cc: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY |
| Date: | 2021-05-06 05:35:34 |
| Message-ID: | CA+HiwqHJK7H6g8+rMhyMtxjgXefzdEk2yKTdB3LCFdNMw4Ct+w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 5, 2021 at 7:59 PM Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru> wrote:
> I found this in the documentation, section '5.11.3. Partitioning Using Inheritance'[1]:
> "Some operations require a stronger lock when using declarative partitioning than when using table inheritance. For example, removing a partition from a partitioned table requires taking an ACCESS EXCLUSIVE lock on the parent table, whereas a SHARE UPDATE EXCLUSIVE lock is enough in the case of regular inheritance."
>
> This point is no longer valid with some restrictions. If the table has a default partition, then removing a partition still requires taking an ACCESS EXCLUSIVE lock.
>
> May be make sense to add some details about DETACH CONCURRENTLY to the section '5.11.2.2. Partition Maintenance' and completely remove this point?
>
> 1. https://www.postgresql.org/docs/devel/ddl-partitioning.html#DDL-PARTITIONING-USING-INHERITANCE
That makes sense, thanks for noticing.
How about the attached?
--
Amit Langote
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| ddl-partitioning-note-detach-concurrenltly.patch | application/octet-stream | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2021-05-06 05:52:09 | Re: Replication slot stats misgivings |
| Previous Message | Andres Freund | 2021-05-06 05:31:40 | Re: gcc 11.1.0 warnings in llvmjit_expr.c |