| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY |
| Date: | 2021-05-06 20:48:29 |
| Message-ID: | 20210506204829.GA8989@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-May-06, Amit Langote wrote:
> That makes sense, thanks for noticing.
>
> How about the attached?
I tweaked the linkage; as submitted, the text in the link contained what
is in the <term> tag, so literally it had:
... see DETACH PARTITION partition_name [ CONCURRENTLY | FINALIZE ] for
details ...
which didn't look very nice. So I made it use <link> instead of xref
and wrote the "ALTER TABLE .. DETACH PARTITION" text. I first tried to
fix it by adding an "xreflabel" attrib, but I didn't like it because the
text was not set in fixed width font.
I also tweaked the wording to match the surrounding text a bit better,
at least IMO. Feel free to suggest improvements.
Thanks!
--
Álvaro Herrera 39°49'30"S 73°17'W
"That sort of implies that there are Emacs keystrokes which aren't obscure.
I've been using it daily for 2 years now and have yet to discover any key
sequence which makes any sense." (Paul Thomas)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-05-06 20:58:28 | Re: AlterSubscription_refresh "wrconn" wrong variable? |
| Previous Message | 盏一 | 2021-05-06 20:36:25 | Re: use `proc->pgxactoff` as the value of `index` in `ProcArrayRemove()` |