| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Replication slot stats misgivings |
| Date: | 2021-05-06 05:52:09 |
| Message-ID: | CALDaNm042Ayb1sY0iRXQuGipwi9tn4VFvqAqsxnQ0DnpWfcVmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 6, 2021 at 9:39 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, May 6, 2021 at 6:15 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > After more thought, I'm concerned that my patch's approach might be
> > invasive for PG14. Given that Vignesh’s patch would cover most cases,
> >
>
> I am not sure if your patch is too invasive but OTOH I am also
> convinced that Vignesh's patch covers most cases and is much simpler
> so we can go ahead with that. In the attached, I have combined
> Vignesh's patch and your doc fix patch. Additionally, I have changed
> some comments and some other cosmetic stuff. Let me know what you
> think of the attached?
The updated patch looks good to me.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2021-05-06 05:52:11 | Re: COPY table_name (single_column) FROM 'unknown.txt' DELIMITER E'\n' |
| Previous Message | Amit Langote | 2021-05-06 05:35:34 | Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY |