| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, sbernikov(at)gmail(dot)com |
| Subject: | Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti |
| Date: | 2021-06-12 01:35:51 |
| Message-ID: | CA+HiwqFx_50RrmR1KYcrb0Q3100-rBxiGKA-qK2W06V-oc+EsA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Sat, Jun 12, 2021 at 5:15 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
> > I see from the coverage report that *none* of the did-not-find-tuple
> > code paths in worker.c are exercised. This does not seem OK. I agree
> > that probably the only way to have a test case is to kick up the debug
> > level to DEBUG1 and grep the log to confirm that the message is there.
> > IIRC, we already have infrastructure for grepping the log, so this
> > shouldn't be that hard. Will work on it today.
>
> Done now. It was a highly worthwhile exercise, too, because I stumbled
> over two *other* bugs in this code while I was at it.
Oh, thanks for taking care of that.
BTW, I intentionally reworded the DEBUG messages to make sure we could
> tell the partitioned case apart from the non-partitioned one.
That looks useful.
> --
Amit Langote
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-12 01:37:05 | Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti |
| Previous Message | Michael Paquier | 2021-06-12 01:31:35 | Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti |