| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, sbernikov(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti |
| Date: | 2021-06-11 20:15:20 |
| Message-ID: | 2058966.1623442520@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
I wrote:
> I see from the coverage report that *none* of the did-not-find-tuple
> code paths in worker.c are exercised. This does not seem OK. I agree
> that probably the only way to have a test case is to kick up the debug
> level to DEBUG1 and grep the log to confirm that the message is there.
> IIRC, we already have infrastructure for grepping the log, so this
> shouldn't be that hard. Will work on it today.
Done now. It was a highly worthwhile exercise, too, because I stumbled
over two *other* bugs in this code while I was at it.
BTW, I intentionally reworded the DEBUG messages to make sure we could
tell the partitioned case apart from the non-partitioned one.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-11 20:31:29 | Re: BUG #17054: Memory corruption in logical replication worker when replicating into partitioned table |
| Previous Message | Tom Lane | 2021-06-11 15:01:07 | Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti |