From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Message style cleanup |
Date: | 2011-05-04 18:32:49 |
Message-ID: | BANLkTim5vK2NUDByqgXEwOaQv=AXMyoFvA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Is this part really correct?
- fprintf(stderr, _("%s: final receive failed: %s\n"),
+ fprintf(stderr, _("%s: final receive failed: %s"),
all other msgs have \n.. I see you removed the final dot in many of
the other messages, did you just accidentally grab one too many?
(There are a couple of other examples of removing the \n though, so
perhaps it was intentional? But they're all preceeding
disconnect_and_exit() so I don't see why it shouldn't be consistent?
//Magnus
On Wed, May 4, 2011 at 20:10, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> Message style cleanup
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/bff074b1ab0dfed7a7822dcc8942f877efa3b914
>
> Modified Files
> --------------
> src/bin/pg_basebackup/pg_basebackup.c | 62 ++++++++++++++++----------------
> 1 files changed, 31 insertions(+), 31 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers
>
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-05-04 19:02:49 | pgsql: Include unary plus in the Operator Precedence table. |
Previous Message | Peter Eisentraut | 2011-05-04 18:10:38 | pgsql: Remove redundant port number check |
From | Date | Subject | |
---|---|---|---|
Next Message | Darren Duncan | 2011-05-04 18:33:33 | Re: VARIANT / ANYTYPE datatype |
Previous Message | Tom Lane | 2011-05-04 18:31:03 | Re: Unfriendly handling of pg_hba SSL options with SSL off |