| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Message style cleanup |
| Date: | 2011-05-04 19:09:54 |
| Message-ID: | 1304536194.18730.2.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On ons, 2011-05-04 at 20:32 +0200, Magnus Hagander wrote:
> Is this part really correct?
>
> - fprintf(stderr, _("%s: final receive failed: %s\n"),
> + fprintf(stderr, _("%s: final receive failed: %s"),
>
> all other msgs have \n.. I see you removed the final dot in many of
> the other messages, did you just accidentally grab one too many?
> (There are a couple of other examples of removing the \n though, so
> perhaps it was intentional? But they're all preceeding
> disconnect_and_exit() so I don't see why it shouldn't be consistent?
The result of PQerrorMessage() already ends in \n.
With that in mind, maybe I missed something?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2011-05-04 19:16:42 | Re: [COMMITTERS] pgsql: Message style cleanup |
| Previous Message | Tom Lane | 2011-05-04 19:02:49 | pgsql: Include unary plus in the Operator Precedence table. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2011-05-04 19:15:15 | Re: 'SGT DETAIL: Could not open file "pg_clog/05DC": No such file or directory' - what to do now? |
| Previous Message | Tom Lane | 2011-05-04 18:50:35 | Re: Extreme bloating of intarray GiST indexes |