Re: pgsql: Fix memory leak in pgbench

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org,Michael Paquier <michael(at)paquier(dot)xyz>,Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: pgsql: Fix memory leak in pgbench
Date: 2019-04-10 06:11:43
Message-ID: A40FECD2-DDED-447F-8616-DC47471EAF6C@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On April 9, 2019 11:07:38 PM PDT, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>On Wed, Apr 10, 2019 at 01:19:11PM +0900, Masahiko Sawada wrote:
>> This change leads a compiler warning on my machine:
>>
>> pgbench.c: In function ‘readCommandResponse’:
>> pgbench.c:2730: warning: ISO C90 forbids mixed declarations and code
>
>C99 does not forbid that (see d9dd406).

Our own set of standards do however. Note that we still have wdeclaration-after-statement in our compiler flags if supported by the compiler. CF configure.in.

Andres

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2019-04-10 06:11:54 Re: pgsql: Fix memory leak in pgbench
Previous Message Fabien COELHO 2019-04-10 06:10:15 Re: pgsql: Fix memory leak in pgbench