| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Dave Cramer <davecramer(at)gmail(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2020-07-05 20:40:16 |
| Message-ID: | A2BD2917-29EC-42E9-AB6E-9B1BB0F6DB7E@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 2 Jul 2020, at 18:41, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>
> rebased
Thanks! The new version of 0001 patch has a compiler warning due to mixed
declarations and code:
worker.c: In function ‘slot_store_data’:
worker.c:366:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
int cursor = tupleData->values[remoteattnum]->cursor;
^
worker.c: In function ‘slot_modify_data’:
worker.c:485:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
int cursor = tupleData->values[remoteattnum]->cursor;
^
I didn't investigate to see if it was new, but Travis is running with Werror
which fails this build.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2020-07-05 20:48:42 | Re: vacuum verbose detail logs are unclear; log at *start* of each stage |
| Previous Message | Pavel Stehule | 2020-07-05 20:37:00 | Re: proposal: possibility to read dumped table's name from file |